🐛 Fixed packages mypy, pylint and tests #6678
Merged
+219
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6678 +/- ##
===============================================================================
+ Coverage 72.29% 74.47% +2.18%
===============================================================================
Files 1038 1184 +146
Lines 44897 47163 +2266
Branches 1316 1528 +212
===============================================================================
+ Hits 32457 35124 +2667
+ Misses 12209 11818 -391
+ Partials 231 221 -10
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
GitHK
requested review from
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
sanderegg
reviewed
Nov 8, 2024
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
there are a few things that are strange. Also setting models to have optional fields has consequences. I would like to check the one with the progress bar at least
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_storage.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/service_settings_labels.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_endpoint.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
Nov 8, 2024
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_dynamic_sidecar/telemetry.py
Show resolved
Hide resolved
giancarloromeo
approved these changes
Nov 8, 2024
…quash_updates' into pr-osparc-pydantic2-fixes-to-libraries2
sanderegg
approved these changes
Nov 8, 2024
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
Please check ClusterCreate. thanks for the other changes.
packages/models-library/src/models_library/api_schemas_directorv2/clusters.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_directorv2/comp_tasks.py
Outdated
Show resolved
Hide resolved
added 7 commits
November 8, 2024 13:04
…quash_updates' into pr-osparc-pydantic2-fixes-to-libraries2
|
GitHK
merged commit f07afbf
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
58 of 90 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Made packages tests green.
Related issue/s
How to test
Dev-ops checklist